vldpyatkov commented on a change in pull request #541:
URL: https://github.com/apache/ignite-3/pull/541#discussion_r781998871
##########
File path:
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItInternalTableScanTest.java
##########
@@ -343,7 +348,7 @@ public void testExceptionRowScanCursorHasNext() throws
Exception {
doAnswer(
invocationClose -> {
- cursorClosed.set(true);
+ cursorClosedLatch.countDown();
Review comment:
There is the same as above: only one waiting expression is enough.
##########
File path:
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItInternalTableScanTest.java
##########
@@ -264,14 +264,14 @@ public void testMultipleRowScan() throws Exception {
*/
@Test()
public void testInvalidRequestedAmountScan() throws Exception {
- AtomicBoolean cursorClosed = new AtomicBoolean(false);
+ CyclicBarrier cursorClosedBarrier = new CyclicBarrier(2);
Review comment:
I think Atomic is enough here.
Because when an exception is already having, the invocation is guaranteed
happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
