ololo3000 commented on a change in pull request #9714:
URL: https://github.com/apache/ignite/pull/9714#discussion_r785751114
##########
File path: modules/core/src/test/java/org/apache/ignite/cdc/CdcSelfTest.java
##########
@@ -98,15 +97,12 @@
return params;
}
- /** Consistent id. */
- private UUID consistentId = UUID.randomUUID();
-
/** {@inheritDoc} */
@Override protected IgniteConfiguration getConfiguration(String
igniteInstanceName) throws Exception {
IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
if (specificConsistentId)
- cfg.setConsistentId(consistentId);
+ cfg.setConsistentId(igniteInstanceName);
Review comment:
> Why you want to avoid it
To avoid meaningless copy-paste.
>Can we revert these changes?
No we can't. The existing tests did not catch the bug this PR is intended to
solve.
##########
File path: modules/core/src/test/java/org/apache/ignite/cdc/CdcSelfTest.java
##########
@@ -98,15 +97,12 @@
return params;
}
- /** Consistent id. */
- private UUID consistentId = UUID.randomUUID();
-
/** {@inheritDoc} */
@Override protected IgniteConfiguration getConfiguration(String
igniteInstanceName) throws Exception {
IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
if (specificConsistentId)
- cfg.setConsistentId(consistentId);
+ cfg.setConsistentId(igniteInstanceName);
Review comment:
> Why you want to avoid it
To avoid meaningless copy-paste.
>Can we revert these changes?
No we can't. The existing tests did not catch the bug this PR is intended to
solve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
