Mmuzaf commented on a change in pull request #9186:
URL: https://github.com/apache/ignite/pull/9186#discussion_r786192752
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotMXBeanImpl.java
##########
@@ -47,4 +51,20 @@ public SnapshotMXBeanImpl(GridKernalContext ctx) {
@Override public void cancelSnapshot(String snpName) {
mgr.cancelSnapshot(snpName).get();
}
+
+ /** {@inheritDoc} */
+ @Override public void restoreSnapshot(String name, String grpNames) {
+ Set<String> grpNamesSet = F.isEmpty(grpNames) ? null :
Review comment:
I'd suggest moving this to internal API and create an overloaded method
in the restore manager doing the same.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java
##########
@@ -988,6 +1020,8 @@ private static GridAffinityAssignmentCache
calculateAffinity(
partFile.toFile(),
snpFile.length());
+
opCtx0.processedParts.incrementAndGet();
Review comment:
I suggest incrementing the counter on PartitinFututre completion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
