zstan commented on a change in pull request #542:
URL: https://github.com/apache/ignite-3/pull/542#discussion_r790751444
##########
File path:
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/externalize/RelJsonReaderTest.java
##########
@@ -71,5 +77,49 @@ void fromJson() {
assertThat(node.getTable(), notNullValue());
assertThat(node.getTable().unwrap(IgniteTable.class),
is(igniteTableMock));
Mockito.verify(schemaMock).tableById(tableId);
+
+ AtomicBoolean tableByIdCalled = new AtomicBoolean();
+ RelJsonReader reader = new RelJsonReader(schemaMock);
+
+ when(schemaMock.tableById(any())).thenAnswer((k) -> {
+ tableByIdCalled.set(true);
+
+ return igniteTableMock;
+ });
+
+ reader.read(json);
+ assertTrue(tableByIdCalled.get());
+ }
+
+ /**
+ * Checks that appropriate methods called form table manager on rel node
construction.
+ */
+ @Test
+ void checkTableManagerCalled() throws Exception {
Review comment:
plz check, is it ok for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
