sashapolo commented on a change in pull request #590:
URL: https://github.com/apache/ignite-3/pull/590#discussion_r791674743
##########
File path:
modules/network/src/main/java/org/apache/ignite/internal/network/netty/ConnectionManager.java
##########
@@ -138,16 +136,12 @@ public void start() throws IgniteInternalException {
throw new IgniteInternalException("Attempted to start an
already stopped connection manager");
}
- //TODO: timeout value should be extracted into common configuration
- // https://issues.apache.org/jira/browse/IGNITE-14538
- server.start().get(3, TimeUnit.SECONDS);
+ server.start().get();
LOG.info("Connection created [address=" + server.address() + ']');
} catch (ExecutionException e) {
Throwable cause = e.getCause();
throw new IgniteInternalException("Failed to start the connection
manager: " + cause.getMessage(), cause);
- } catch (TimeoutException e) {
- throw new IgniteInternalException("Timeout while waiting for the
connection manager to start", e);
} catch (InterruptedException e) {
throw new IgniteInternalException("Interrupted while starting the
connection manager", e);
Review comment:
we should preserve the interrupted flag here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
