ololo3000 commented on a change in pull request #98:
URL: https://github.com/apache/ignite-extensions/pull/98#discussion_r791774525
##########
File path:
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/conflictresolve/CacheConflictResolutionManagerImpl.java
##########
@@ -38,22 +39,42 @@
*/
private final String conflictResolveField;
+ /** CLuster Id. */
+ private final byte clusterId;
+
/** Grid cache context. */
private GridCacheContext<K, V> cctx;
/**
* @param conflictResolveField Field to resolve conflicts.
*/
- public CacheConflictResolutionManagerImpl(String conflictResolveField) {
+ public CacheConflictResolutionManagerImpl(String conflictResolveField,
byte clusterId) {
this.conflictResolveField = conflictResolveField;
+ this.clusterId = clusterId;
}
/** {@inheritDoc} */
@Override public CacheVersionConflictResolver conflictResolver() {
+ cctx.logger(this.getClass()).info("Conflict resolver created [" +
+ "cache=" + cctx.name() +
+ ", clusterId=" + clusterId +
+ ", conflictResolveField=" + conflictResolveField + ']'
+ );
+
+ IgniteLogger log = cctx.logger(CacheVersionConflictResolverImpl.class);
Review comment:
cctx.logger() creates new logger instance each time it is called. Do we
need it? May be it is better to save it once in the dedicated variable?
##########
File path:
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/CacheConflictOperationsTest.java
##########
@@ -41,6 +41,7 @@
import org.apache.ignite.internal.processors.cache.KeyCacheObjectImpl;
import org.apache.ignite.internal.processors.cache.dr.GridCacheDrInfo;
import org.apache.ignite.internal.processors.cache.version.GridCacheVersion;
+import org.apache.ignite.testframework.GridTestUtils;
Review comment:
Unused import.
##########
File path:
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/conflictresolve/CacheVersionConflictResolverPluginProvider.java
##########
@@ -123,9 +135,16 @@ public void setConflictResolveField(String
conflictResolveField) {
this.conflictResolveField = conflictResolveField;
}
+ /** @param name Plugin name. */
+ public void setName(String name) {
+ this.name = name;
+ }
+
/** {@inheritDoc} */
@Override public void start(PluginContext ctx) {
- // No-op.
+ IgniteEx ign = (IgniteEx)ctx.grid();
Review comment:
It seems that that we don't need ctx variable anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
