korlov42 commented on a change in pull request #9671:
URL: https://github.com/apache/ignite/pull/9671#discussion_r793338127
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rel/IgniteIndexScan.java
##########
@@ -39,13 +41,18 @@
/** */
private final long sourceId;
+ /** */
+ private final RelCollation idxCollation;
+
/**
* Constructor used for deserialization.
*
* @param input Serialized representation.
*/
public IgniteIndexScan(RelInput input) {
- super(changeTraits(input, IgniteConvention.INSTANCE));
+ super(changeTraits(input, IgniteConvention.INSTANCE,
input.getCollation()));
Review comment:
probably, it would be better to introduce a separate field, rather than
modify traits. For example, the Sort relation does so
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rule/logical/ExposeIndexRule.java
##########
@@ -68,6 +68,9 @@ private static boolean preMatch(IgniteLogicalTableScan scan) {
RexNode condition = scan.condition();
ImmutableBitSet requiredCols = scan.requiredColumns();
+ if (igniteTable.isIndexRebuildInProgress())
Review comment:
does it make sense to check it in preMatch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
