isapego commented on a change in pull request #599:
URL: https://github.com/apache/ignite-3/pull/599#discussion_r794415384
##########
File path:
modules/platforms/dotnet/Apache.Ignite/Internal/Proto/MessagePackReaderExtensions.cs
##########
@@ -137,8 +137,8 @@ public static unsafe IgniteUuid ReadIgniteUuid(this ref
MessagePackReader reader
var size = ValidateExtensionType(ref reader,
ClientMessagePackType.IgniteUuid);
var bytes = reader.ReadRaw(size);
- var res = default(IgniteUuid);
- bytes.CopyTo(new Span<byte>(res.Bytes, size));
+ IgniteUuid res = default;
+ bytes.CopyTo(new Span<byte>(&res, size));
res.Size = (byte)size;
Review comment:
Should we add an assertion here, that size is less than 127?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
