xtern commented on a change in pull request #9422:
URL: https://github.com/apache/ignite/pull/9422#discussion_r795072615
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java
##########
@@ -1882,6 +1898,20 @@ static void copy(FileIOFactory factory, File from, File
to, long length) {
return new
IgniteFutureImpl<>(cctx.kernalContext().task().execute(taskCls, snpName));
}
+ /**
+ * @param snpName Snapshot name.
+ * @return Snapshot view.
+ */
+ private SnapshotView snapshotViewSupplier(String snpName) {
+ SnapshotMetadata meta = readSnapshotMetadata(snpName,
+
toStringSafe(cctx.kernalContext().discovery().localNode().consistentId()));
Review comment:
It is possible that the local node also stores snapshots from another
node, we should display those as well, not just the local one.
My suggestion is to change the data supplier to something like this (in a
separate method `readSnapshotMetadatas()`):
```
() ->
localSnapshotNames().stream().map(this::readSnapshotMetadatas).flatMap(List::stream).collect(Collectors.toList()),
```
and replace the current argument of `snapshotViewSupplier(String snpName)`
to `snapshotViewSupplier(SnapshotMetadata meta)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
