zstan commented on a change in pull request #604:
URL: https://github.com/apache/ignite-3/pull/604#discussion_r795608568
##########
File path:
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/jdbc/ItJdbcMetadataSelfTest.java
##########
@@ -204,13 +205,34 @@ public void testGetColumns() throws Exception {
ResultSet rs = meta.getColumns("IGNITE", "PUBLIC", "PERSON", "%");
+ checkPersonTableColumns(rs);
+
+ rs = meta.getColumns(null, "PUBLIC", "PERSON", null);
+
+ checkPersonTableColumns(rs);
+
+ rs = meta.getColumns("IGNITE", "PUBLIC", "ORGANIZATION", "%");
+
+ checkOrgTableColumns(rs);
+
+ rs = meta.getColumns(null, "PUBLIC", "ORGANIZATION", null);
+
+ checkOrgTableColumns(rs);
+ }
+
+ /**
+ * Checks organisation table column names and types.
+ *
+ * @param rs ResultSet.
+ * */
+ private void checkOrgTableColumns(ResultSet rs) throws SQLException {
assertNotNull(rs);
- Collection<String> names = new ArrayList<>(2);
+ List<String> names = new ArrayList<>();
Review comment:
Collection - you don`t need ordered List here, just for code
clarification with equal functionality in : checkPersonTableColumns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
