AMashenkov commented on a change in pull request #9780:
URL: https://github.com/apache/ignite/pull/9780#discussion_r795745540



##########
File path: 
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2Table.java
##########
@@ -988,6 +988,8 @@ public void rollbackUserIndex(String idxName) {
             GridH2IndexBase rmvIdx = tmpIdxs.remove(idxName);
 
             assert rmvIdx != null;
+
+            rmvIdx.destroy(true);

Review comment:
       I'm not sure dropping index only on closure failure will be helpful, 
because destroy operation may fail either.
     
   I think we should destroy orphan indices on table start (on or after WAL 
recovery) as well, due to the index tree can't be reused by the rebuild 
operation. 
   
   If we can't detect and drop orphan index tree on WAL recovery synchronously, 
then we should drop orphans on cache destroy as well, because cache could be 
dropped concurrently while recovery task isn't started yet. 
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to