AMashenkov commented on a change in pull request #611:
URL: https://github.com/apache/ignite-3/pull/611#discussion_r797716165



##########
File path: 
modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/ClientMessageUnpacker.java
##########
@@ -742,26 +741,6 @@ public UUID unpackUuid() {
         return new UUID(buf.readLong(), buf.readLong());
     }
 
-    /**
-     * Reads an {@link IgniteUuid}.
-     *
-     * @return {@link IgniteUuid} value.
-     * @throws MessageTypeException when type is not {@link IgniteUuid}.
-     * @throws MessageSizeException when size is not correct.
-     */
-    public IgniteUuid unpackIgniteUuid() {

Review comment:
       @ptupitsyn 
   do we really want to drop IgniteUuid from protocol?
   It may be useful e.g. for request ids, which require cluster-wide uniqueness 
and its generation is on hot path.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to