tledkov-gridgain commented on a change in pull request #510:
URL: https://github.com/apache/ignite-3/pull/510#discussion_r800481830
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/registry/SchemaRegistryImpl.java
##########
@@ -151,40 +152,48 @@ public Row resolve(BinaryRow row, SchemaDescriptor
schemaDescriptor) {
/** {@inheritDoc} */
@Override
- public Collection<Row> resolve(Collection<BinaryRow> rows) {
+ public Collection<Row> resolve(Collection<BinaryRow> binaryRows) {
final SchemaDescriptor curSchema = waitLatestSchema();
- return rows.stream().map(row -> resolveInternal(row,
curSchema)).collect(toList());
+ List<Row> rows = new ArrayList<>(binaryRows.size());
+
+ for (BinaryRow r : binaryRows) {
+ if (r != null) {
Review comment:
Which case produces `r == null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
