alex-plekhanov commented on a change in pull request #9800:
URL: https://github.com/apache/ignite/pull/9800#discussion_r800496184
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rel/agg/IgniteSortAggregateBase.java
##########
@@ -48,7 +47,22 @@
@Override default Pair<RelTraitSet, List<RelTraitSet>>
passThroughCollation(
RelTraitSet nodeTraits, List<RelTraitSet> inputTraits
) {
- RelCollation collation =
RelCollations.of(ImmutableIntList.copyOf(getGroupSet().asList()));
+ RelCollation required = TraitUtils.collation(nodeTraits);
+ ImmutableBitSet requiredKeys = ImmutableBitSet.of(required.getKeys());
+ RelCollation collation;
+
+ if (getGroupSet().contains(requiredKeys)) {
Review comment:
What is the difference? `requiredKeys` is a subset of `groupSet`, so
size of `required + keysLeft = required + (groupSet - required) = groupSet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
