nizhikov commented on a change in pull request #99:
URL: https://github.com/apache/ignite-extensions/pull/99#discussion_r812318399
##########
File path:
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/IgniteToKafkaCdcStreamer.java
##########
@@ -110,37 +130,17 @@
/** Count of sent messages. */
private AtomicLongMetric msgsSnt;
+ /** */
+ public IgniteToKafkaCdcStreamer() {
+ // No-op.
+ }
+
/**
- * @param topic Topic name.
- * @param kafkaParts Kafka partitions count.
- * @param caches Cache names.
- * @param maxBatchSize Maximum size of records concurrently sent to Kafka.
- * @param onlyPrimary If {@code true} then stream only events from
primaries.
* @param kafkaProps Kafka properties.
*/
- public IgniteToKafkaCdcStreamer(
- String topic,
- int kafkaParts,
- Set<String> caches,
- int maxBatchSize,
- boolean onlyPrimary,
- Properties kafkaProps
- ) {
- assert caches != null && !caches.isEmpty();
-
- this.topic = topic;
- this.kafkaParts = kafkaParts;
- this.onlyPrimary = onlyPrimary;
+ public IgniteToKafkaCdcStreamer(Properties kafkaProps) {
Review comment:
Can we get rid of this constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
