rpuch commented on a change in pull request #690:
URL: https://github.com/apache/ignite-3/pull/690#discussion_r816804672
##########
File path:
modules/rest/src/main/java/org/apache/ignite/internal/rest/RestModule.java
##########
@@ -17,136 +17,73 @@
package org.apache.ignite.internal.rest;
-import static io.netty.handler.codec.http.HttpHeaderValues.APPLICATION_JSON;
-import static io.netty.handler.codec.http.HttpResponseStatus.BAD_REQUEST;
-
import io.netty.bootstrap.ServerBootstrap;
import io.netty.channel.Channel;
import io.netty.channel.ChannelFuture;
import io.netty.handler.logging.LogLevel;
import io.netty.handler.logging.LoggingHandler;
import java.net.BindException;
-import java.nio.charset.StandardCharsets;
-import java.util.Map;
-import java.util.concurrent.CompletableFuture;
-import java.util.concurrent.CompletionException;
+import java.util.function.Consumer;
import org.apache.ignite.configuration.schemas.rest.RestConfiguration;
import org.apache.ignite.configuration.schemas.rest.RestView;
-import
org.apache.ignite.configuration.validation.ConfigurationValidationException;
import org.apache.ignite.internal.configuration.ConfigurationManager;
import org.apache.ignite.internal.configuration.ConfigurationRegistry;
import org.apache.ignite.internal.manager.IgniteComponent;
-import org.apache.ignite.internal.rest.netty.RestApiHttpRequest;
-import org.apache.ignite.internal.rest.netty.RestApiHttpResponse;
import org.apache.ignite.internal.rest.netty.RestApiInitializer;
-import org.apache.ignite.internal.rest.presentation.ConfigurationPresentation;
-import org.apache.ignite.internal.rest.presentation.hocon.HoconPresentation;
import org.apache.ignite.internal.rest.routes.Router;
+import org.apache.ignite.internal.rest.routes.SimpleRouter;
import org.apache.ignite.lang.IgniteException;
import org.apache.ignite.lang.IgniteLogger;
import org.apache.ignite.network.NettyBootstrapFactory;
+import org.apache.ignite.rest.RestHandlersRegister;
+import org.apache.ignite.rest.Routes;
/**
* Rest module is responsible for starting a REST endpoints for accessing and
managing configuration.
*
- * <p>It is started on port 10300 by default but it is possible to change this
in configuration itself. Refer to default config file in
+ * <p>It is started on port 10300 by default, but it is possible to change
this in configuration itself. Refer to default config file in
* resources for the example.
*/
-public class RestModule implements IgniteComponent {
- /** Default port. */
- public static final int DFLT_PORT = 10300;
-
- /** Node configuration route. */
- private static final String NODE_CFG_URL =
"/management/v1/configuration/node/";
-
- /** Cluster configuration route. */
- private static final String CLUSTER_CFG_URL =
"/management/v1/configuration/cluster/";
-
- /** Path parameter. */
- private static final String PATH_PARAM = "selector";
-
+public class RestModule implements RestHandlersRegister, IgniteComponent {
/** Ignite logger. */
private final IgniteLogger log = IgniteLogger.forClass(RestModule.class);
/** Node configuration register. */
private final ConfigurationRegistry nodeCfgRegistry;
- /** Presentation of node configuration. */
- private final ConfigurationPresentation<String> nodeCfgPresentation;
-
- /** Presentation of cluster configuration. */
- private final ConfigurationPresentation<String> clusterCfgPresentation;
-
/** Netty bootstrap factory. */
private final NettyBootstrapFactory bootstrapFactory;
+ private final SimpleRouter router = new SimpleRouter();
+
/** Netty channel. */
private volatile Channel channel;
Review comment:
This should probably be implemented in a separate issue.
I filed a ticket about this:
https://issues.apache.org/jira/browse/IGNITE-16636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
