isapego commented on a change in pull request #9862:
URL: https://github.com/apache/ignite/pull/9862#discussion_r818407070
##########
File path: modules/platforms/cpp/odbc/src/query/batch_query.cpp
##########
@@ -144,23 +144,12 @@ namespace ignite
{
const std::string& schema = connection.GetSchema();
- QueryExecuteBatchRequest req(schema, sql, params, begin, end,
last, timeout,
- connection.IsAutoCommit());
+ QueryExecuteBatchRequest req(schema, sql, params, begin, end,
last, timeout, connection.IsAutoCommit());
QueryExecuteBatchResponse rsp;
try
{
- // Setting connection timeout to 1 second more than query
timeout itself.
- int32_t connectionTimeout = timeout ? timeout + 1 : 0;
-
- bool success = connection.SyncMessage(req, rsp,
connectionTimeout);
-
- if (!success)
- {
- diag.AddStatusRecord(SqlState::SHYT00_TIMEOUT_EXPIRED,
"Query timeout expired");
-
- return SqlResult::AI_ERROR;
- }
+ connection.SyncMessage(req, rsp);
Review comment:
Sure. We just use connection's timeout for network-related operations
here, which seems more right according to specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
