AMashenkov commented on a change in pull request #708:
URL: https://github.com/apache/ignite-3/pull/708#discussion_r822526322
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/definition/builder/PrimaryKeyDefinitionBuilderImpl.java
##########
@@ -98,12 +98,12 @@ public PrimaryKeyDefinition build() {
Set<String> cols = Set.copyOf(columns);
- Set<String> affCols;
+ List<String> affCols;
if (CollectionUtils.nullOrEmpty(affinityColumns)) {
- affCols = cols;
+ affCols = List.copyOf(columns);
} else {
- affCols = Set.copyOf(affinityColumns);
+ affCols = List.copyOf(affinityColumns);
Review comment:
@ygerzhedovich, affinityColumns are checked few lines below.
But affinityColumns are not checked in SchemaConfigurationConverter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
