timoninmaxim commented on a change in pull request #9837:
URL: https://github.com/apache/ignite/pull/9837#discussion_r823574958
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/sql/SqlKeyword.java
##########
@@ -347,7 +348,11 @@
* @return {@code True} if it is a keyword.
*/
public static boolean isKeyword(String str) {
- return KEYWORDS.contains(str);
+ boolean isFallback =
IgniteSystemProperties.getBoolean(IgniteSystemProperties.IGNITE_SQL_PARSER_DISABLE_H2_FALLBACK);
Review comment:
We should not skip checking `isKeyword` for most of cases. But only for
specific ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
