ibessonov commented on a change in pull request #715:
URL: https://github.com/apache/ignite-3/pull/715#discussion_r824745755
##########
File path:
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
##########
@@ -411,6 +413,12 @@ public void setBaseline(Set<String> baselineNodes) {
}
}
+ /** {@inheritDoc} */
+ @Override
+ public IgniteCompute compute() {
+ return new IgniteComputeImpl();
Review comment:
I know that it's good enough for now, but why not field?
##########
File path:
modules/compute-api/src/main/java/org/apache/ignite/compute/ComputeJob.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.compute;
+
+/**
+ * A Compute job that may be executed on an Ignite node (or a few nodes, or on
the whole cluster).
+ *
+ * @param <R> job result type
+ */
+public interface ComputeJob<R> {
+ /**
+ * Executes the job on an Ignite node.
+ *
+ * @param context context
+ * @param args job arguments
Review comment:
This javadoc will have to be expanded in the future, right? Currently, I
don't understand supported argument types, for example
##########
File path:
modules/compute/src/test/java/org/apache/ignite/internal/compute/IgniteComputeImplTest.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.compute;
+
+import org.apache.ignite.compute.IgniteCompute;
+import org.junit.jupiter.api.Test;
+
+class IgniteComputeImplTest {
Review comment:
Do we really need this test?
##########
File path:
modules/compute-api/src/main/java/org/apache/ignite/compute/ComputeJob.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.compute;
+
+/**
+ * A Compute job that may be executed on an Ignite node (or a few nodes, or on
the whole cluster).
+ *
+ * @param <R> job result type
+ */
+public interface ComputeJob<R> {
Review comment:
Do we have serializability requirement right now? Just asking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
