isapego commented on a change in pull request #719:
URL: https://github.com/apache/ignite-3/pull/719#discussion_r826015462
##########
File path: modules/platforms/dotnet/Apache.Ignite/IgniteClientConfiguration.cs
##########
@@ -97,5 +99,24 @@ public IgniteClientConfiguration(IgniteClientConfiguration
other)
/// * my-host.com:780..787 (custom port range).
/// </summary>
public IList<string> Endpoints { get; } = new List<string>();
+
+ /// <summary>
+ /// Gets or sets the retry policy. When a request fails due to a
connection error,
+ /// Ignite will retry the request if the specified policy allows it.
+ /// <para />
+ /// Default is <see cref="RetryNonePolicy"/> - does not retry anything.
+ /// <para />
+ /// See also <see cref="RetryAllPolicy"/>, <see
cref="RetryReadPolicy"/>, <see cref="RetryNonePolicy"/>, <see
cref="RetryLimit"/>.
+ /// </summary>
+ public IRetryPolicy RetryPolicy { get; set; } =
RetryNonePolicy.Instance;
+
+ /// <summary>
+ /// Gets or sets the retry limit. When a request fails due to a
connection error,
+ /// Ignite will retry the request if the specified <see
cref="RetryPolicy"/> allows it. When this property is
+ /// greater than <c>0</c>, Ignite will limit the number of retries.
+ /// <para />
+ /// Default is <c>0</c>: no limit on retries.
+ /// </summary>
+ public int RetryLimit { get; set; }
Review comment:
But some policies may not use retry limit logic (like
`RetryNonePolicy`). Duplication issue is easy to solve wiht inheretance, is not
it?
##########
File path: modules/platforms/dotnet/Apache.Ignite/IgniteClientConfiguration.cs
##########
@@ -97,5 +99,24 @@ public IgniteClientConfiguration(IgniteClientConfiguration
other)
/// * my-host.com:780..787 (custom port range).
/// </summary>
public IList<string> Endpoints { get; } = new List<string>();
+
+ /// <summary>
+ /// Gets or sets the retry policy. When a request fails due to a
connection error,
+ /// Ignite will retry the request if the specified policy allows it.
+ /// <para />
+ /// Default is <see cref="RetryNonePolicy"/> - does not retry anything.
+ /// <para />
+ /// See also <see cref="RetryAllPolicy"/>, <see
cref="RetryReadPolicy"/>, <see cref="RetryNonePolicy"/>, <see
cref="RetryLimit"/>.
+ /// </summary>
+ public IRetryPolicy RetryPolicy { get; set; } =
RetryNonePolicy.Instance;
+
+ /// <summary>
+ /// Gets or sets the retry limit. When a request fails due to a
connection error,
+ /// Ignite will retry the request if the specified <see
cref="RetryPolicy"/> allows it. When this property is
+ /// greater than <c>0</c>, Ignite will limit the number of retries.
+ /// <para />
+ /// Default is <c>0</c>: no limit on retries.
+ /// </summary>
+ public int RetryLimit { get; set; }
Review comment:
But some policies may not use retry limit logic (like
`RetryNonePolicy`). Duplication issue is easy to solve with inheretance, is not
it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
