tledkov-gridgain commented on a change in pull request #738:
URL: https://github.com/apache/ignite-3/pull/738#discussion_r831400416
##########
File path:
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItInternalTableScanTest.java
##########
@@ -527,7 +543,7 @@ public void onSubscribe(Subscription subscription) {
public void onNext(BinaryRow item) {
retrievedItems.add(item);
- if (retrievedItems.size() % reqAmount == 0) {
+ if (reqAmount != Long.MAX_VALUE && retrievedItems.size() %
reqAmount == 0) {
Review comment:
What for additional condition `reqAmount != Long.MAX_VALUE` is added?
Is the condition `retrievedItems.size() % reqAmount` **true** in this case?
##########
File path:
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItInternalTableScanTest.java
##########
@@ -527,7 +543,7 @@ public void onSubscribe(Subscription subscription) {
public void onNext(BinaryRow item) {
retrievedItems.add(item);
- if (retrievedItems.size() % reqAmount == 0) {
+ if (reqAmount != Long.MAX_VALUE && retrievedItems.size() %
reqAmount == 0) {
Review comment:
What for additional condition `reqAmount != Long.MAX_VALUE` is added?
Is the condition `retrievedItems.size() % reqAmount` **true** in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
