tkalkirill commented on code in PR #762:
URL: https://github.com/apache/ignite-3/pull/762#discussion_r842773339
##########
modules/client/src/test/java/org/apache/ignite/client/ReconnectTest.java:
##########
@@ -43,7 +43,7 @@ void tearDown() throws Exception {
@Test
public void clientReconnectsToAnotherAddressOnNodeFail() throws Exception {
FakeIgnite ignite1 = new FakeIgnite();
- ignite1.tables().createTable("t", c -> c.changeName("t"));
+ ignite1.tables().createTable("t", c -> {});
Review Comment:
Maybe add a consumer doing nothing to **ConfigurationTestUtils**?
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/util/ConfigurationSerializationUtil.java:
##########
@@ -200,7 +200,7 @@
buf.put(header);
for (int i = 0; i < strings.length; i++) {
- buf.putInt(strings[i].length());
+ buf.putInt(strBytes[i].length);
Review Comment:
Can use regular loops instead of streams above?
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/tree/NamedListNode.java:
##########
@@ -279,10 +279,14 @@ public int size() {
throw elementRemovedException(oldKey);
}
+ element = element.copy();
Review Comment:
What is this for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
