xtern commented on code in PR #9955:
URL: https://github.com/apache/ignite/pull/9955#discussion_r845863537
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheLifecycleAwareSelfTest.java:
##########
@@ -203,6 +184,13 @@ public TestEvictionPolicy() {
@Override public boolean evictAllowed(Cache.Entry entry) {
return false;
}
+
+ /** {@inheritDoc} */
+ @Override public void start() {
Review Comment:
AFAIK,
this method works incorrectly - please add assertion
`assertNotNull(expCacheName)`.
we don't need this method - we just need to add `Serializable` marker to
`TestLifecycleAware`.
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheLifecycleAwareSelfTest.java:
##########
@@ -175,21 +171,6 @@ public TestAffinityFunction() {
}
}
- /**
- */
- public static class TestEvictionPolicy extends TestLifecycleAware
implements EvictionPolicy, Serializable {
Review Comment:
Why we removed eviction policy from testing?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheLifecycleAwareSelfTest.java:
##########
@@ -234,6 +222,13 @@ private TestInterceptor() {
super(CACHE_NAME);
}
+ /** {@inheritDoc} */
+ @Override public void start() {
Review Comment:
Same goes here - we don't need this method - we just need to add
`Serializable` marker to `TestLifecycleAware`.
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheLifecycleAwareSelfTest.java:
##########
@@ -318,31 +313,10 @@ public TestTopologyValidator() {
lifecycleAwares.add(affinity);
- TestEvictionPolicy evictionPlc = new TestEvictionPolicy();
-
- ccfg.setEvictionPolicy(evictionPlc);
- ccfg.setOnheapCacheEnabled(true);
-
- lifecycleAwares.add(evictionPlc);
-
- if (near) {
Review Comment:
If we remove evictionPolicy from testing - we should remove `near` test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
