tkalkirill commented on code in PR #763:
URL: https://github.com/apache/ignite-3/pull/763#discussion_r846005696
##########
modules/configuration-annotation-processor/src/main/java/org/apache/ignite/internal/configuration/processor/Processor.java:
##########
@@ -487,13 +487,22 @@ private void createPojoBindings(
TypeVariableName typeVariable = TypeVariableName.get("T",
changeClsName, POLYMORPHIC_CHANGE_CLASSNAME);
// Method like: <T extends SimpleChange> T convert(Class<T>
changeClass);
- MethodSpec.Builder convertMtdBuilder =
MethodSpec.methodBuilder("convert")
+ MethodSpec.Builder convertByChangeClassMtdBuilder =
MethodSpec.methodBuilder("convert")
.addModifiers(PUBLIC, ABSTRACT)
.addTypeVariable(typeVariable)
.addParameter(parameterType, "changeClass")
.returns(TypeVariableName.get("T"));
- changeClsBuilder.addMethod(convertMtdBuilder.build());
+ changeClsBuilder.addMethod(convertByChangeClassMtdBuilder.build());
+
+ // Method like: <T extends SimpleChange> T convert(String
polymorphicId);
Review Comment:
Fixed it, now it will be: `SimpleChange convert(String polymorphicId)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
