ptupitsyn commented on code in PR #9960:
URL: https://github.com/apache/ignite/pull/9960#discussion_r848006671
##########
modules/platforms/cpp/common/os/linux/include/ignite/common/concurrent_os.h:
##########
@@ -743,6 +743,13 @@ namespace ignite
* @return Number of logical processors.
*/
IGNITE_IMPORT_EXPORT uint32_t GetNumberOfProcessors();
+
+ /**
+ * Get current processor thread count.
+ *
+ * @return Current processor thread count.
Review Comment:
```suggestion
* @return Current process thread count.
```
##########
modules/platforms/cpp/thin-client-test/src/ignite_client_test.cpp:
##########
@@ -71,14 +72,52 @@ class IgniteClientTestSuiteFixture
BOOST_CHECK_EQUAL(GetActiveConnections(), expect);
}
+ /**
+ * Check that client started with specified size of user thread pool
started exactly the specified number of threads
+ * in thread pool.
+ *
+ * @param cfg Client configuration.
+ * @param num Expected thread number
+ */
+ static void CheckThreadsNum(IgniteClientConfiguration &cfg, uint32_t num)
+ {
+ ignite::TestServer server;
+ server.PushHandshakeResponse(true);
+ server.Start();
+
+ int32_t threadsBefore = ignite::common::concurrent::GetThreadsCount();
Review Comment:
`GetThreadsCount` is used only for tests, should we keep it in the `common`
module?
##########
modules/platforms/cpp/common/os/win/include/ignite/common/concurrent_os.h:
##########
@@ -652,6 +653,13 @@ namespace ignite
* @return Number of logical processors.
*/
IGNITE_IMPORT_EXPORT uint32_t GetNumberOfProcessors();
+
+ /**
+ * Get current processor thread count.
Review Comment:
```suggestion
* Get current process thread count.
```
##########
modules/platforms/cpp/common/os/win/include/ignite/common/concurrent_os.h:
##########
@@ -652,6 +653,13 @@ namespace ignite
* @return Number of logical processors.
*/
IGNITE_IMPORT_EXPORT uint32_t GetNumberOfProcessors();
+
+ /**
+ * Get current processor thread count.
+ *
+ * @return Current processor thread count.
Review Comment:
```suggestion
* @return Current process thread count.
```
##########
modules/platforms/cpp/common/os/linux/include/ignite/common/concurrent_os.h:
##########
@@ -743,6 +743,13 @@ namespace ignite
* @return Number of logical processors.
*/
IGNITE_IMPORT_EXPORT uint32_t GetNumberOfProcessors();
+
+ /**
+ * Get current processor thread count.
Review Comment:
```suggestion
* Get current process thread count.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
