ademakov commented on code in PR #775: URL: https://github.com/apache/ignite-3/pull/775#discussion_r849733677
########## modules/schema/src/main/java/org/apache/ignite/internal/schema/row/InnerTuple.java: ########## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.schema.row; + +import java.math.BigDecimal; +import java.math.BigInteger; +import java.time.Instant; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.time.LocalTime; +import java.util.BitSet; +import java.util.UUID; +import org.apache.ignite.internal.schema.InvalidTypeException; + +/** + * General interface to describe binary tuples outside of their data layout and column schemas. + * Accessor methods may or may not throw {@link InvalidTypeException} depending on the implementation. + */ +public interface InnerTuple { + /** + * Returns a number of values in the tuple. + */ + int count(); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + byte byteValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + Byte byteValueBoxed(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + short shortValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + Short shortValueBoxed(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + int intValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + Integer intValueBoxed(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + long longValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + Long longValueBoxed(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + float floatValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + Float floatValueBoxed(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + double doubleValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + Double doubleValueBoxed(int col); + + /** + * Reads value from specified column. + * + * @param col Column index. + * @return Column value. + */ + BigDecimal decimalValue(int col); + + /** + * Reads value from specified column. + * + * @param col Column index. + * @return Column value. + */ + BigInteger numberValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + String stringValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + byte[] bytesValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + UUID uuidValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + BitSet bitmaskValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + LocalDate dateValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + LocalTime timeValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + LocalDateTime dateTimeValue(int col); + + /** + * Reads value for specified column. + * + * @param col Column index. + * @return Column value. + */ + Instant timestampValue(int col); + + /** + * Checks whether the given column contains a null value. + * + * @param col Column index. + * @return {@code true} if this column contains a null value, {@code false} otherwise. + */ + boolean hasNullValue(int col); Review Comment: Just a matter of personal taste, I would move this up, just after the count() method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
