SammyVimes commented on code in PR #781:
URL: https://github.com/apache/ignite-3/pull/781#discussion_r851783526
##########
modules/platforms/dotnet/Apache.Ignite.Tests/RawSocketConnectionTests.cs:
##########
@@ -83,7 +83,8 @@ private static unsafe void ReadHandshake(NetworkStream stream)
var str = Encoding.UTF8.GetString(msg);
- Assert.AreEqual(110, msgSize, str);
+ // Different size is caused by different node names in response
(PlatformTestNodeRunner or PlatformTestNodeRunner_2).
+ Assert.LessOrEqual(110, msgSize, str);
Review Comment:
```suggestion
StringAssert.Contains(str, "PlatformTestNodeRunner");
```
Makes more sense as there is no hard-coded byte length
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
