tkalkirill commented on code in PR #783:
URL: https://github.com/apache/ignite-3/pull/783#discussion_r854966111
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java:
##########
@@ -47,18 +49,34 @@
* An implementation of the {@link PrepareService} that uses a Calcite-based
query planner to validate and optimize a given query.
*/
public class PrepareServiceImpl implements PrepareService {
- private final DdlSqlToCommandConverter ddlConverter = new
DdlSqlToCommandConverter();
+ private final DdlSqlToCommandConverter ddlConverter;
+
+ /**
+ * Constructor.
+ *
+ * @param dataStorageManager Data storage manager.
+ * @param tablesConfig Tables configuration.
+ * @param dataStorageFields Data storage fields. Mapping: Data storage
name -> field name -> field type.
+ */
+ public PrepareServiceImpl(
+ DataStorageManager dataStorageManager,
+ TablesConfiguration tablesConfig,
+ Map<String, Map<String, Class<?>>> dataStorageFields
+ ) {
+ ddlConverter = new DdlSqlToCommandConverter(
+ dataStorageFields,
+ () ->
dataStorageManager.defaultDataStorage(tablesConfig.defaultDataStorage().value())
Review Comment:
Fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
