sashapolo commented on code in PR #677:
URL: https://github.com/apache/ignite-3/pull/677#discussion_r856302824
##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/LocalConfigurationStorage.java:
##########
@@ -46,17 +46,17 @@ public class LocalConfigurationStorage implements
ConfigurationStorage {
/** Prefix that we add to configuration keys to distinguish them in
metastorage. */
private static final String LOC_PREFIX = "loc-cfg.";
+ /** Key for the storage revision version. */
+ private static final ByteArray VERSION_KEY = new ByteArray(LOC_PREFIX +
"$version");
Review Comment:
> I wonder whether we should use version key outside of the config key range
This key starts with the common prefix on purpose, so that we can read the
version in the `readAll` method in a single scan
> If we still use the current key, we should probably validate that during
write VERSION_KEY property is not written explicitly
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
