rpuch commented on code in PR #790:
URL: https://github.com/apache/ignite-3/pull/790#discussion_r856313017
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/impl/RocksDbSharedLogStorage.java:
##########
@@ -123,8 +121,11 @@ private static class EmptyWriteContext implements
WriteContext {
/** Write lock. */
private final Lock writeLock = this.readWriteLock.writeLock();
Review Comment:
It seems that `readLock` and `writeLock` are not optimal names here, because
they are not about reading and writing (both for read/write operations in this
class, readLock is taken), but for 'managing the service' (start/stop/reset)
and 'using' it. How about renaming them to `manageLock` and `useLock`, or
`exclusiveLock` and `nonExclusiveLock`?
Just a suggestion :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
