sanpwc commented on code in PR #759:
URL: https://github.com/apache/ignite-3/pull/759#discussion_r857674365
##########
modules/api/src/main/java/org/apache/ignite/Ignite.java:
##########
@@ -61,27 +58,6 @@ public interface Ignite extends AutoCloseable {
*/
IgniteSql sql();
- /**
- * Set new baseline nodes for table assignments.
- *
- * <p>Current implementation has significant restrictions: - Only alive
nodes can be a part of new baseline. If any passed nodes are not
- * alive, {@link IgniteException} with appropriate message will be thrown.
- Potentially it can be a long operation and current
- * synchronous changePeers-based implementation can't handle this issue
well. - No recovery logic supported, if setBaseline fails - it
- * can produce random state of cluster.
- * TODO: IGNITE-14209 issues above must be fixed.
- * TODO: IGNITE-15815 add a test for stopping node and asynchronous
implementation.
- *
- * @param baselineNodes Names of baseline nodes.
- * @throws IgniteException If an unspecified platform exception has
happened internally. Is thrown when:
- * <ul>
- * <li>the node is stopping,</li>
- * <li>{@code baselineNodes} argument is empty
or null,</li>
- * <li>any node from {@code baselineNodes} is
not alive.</li>
- * </ul>
- */
- @Experimental
- void setBaseline(Set<String> baselineNodes);
Review Comment:
Seems that also there are some (one(?)) mentions of setBaseline(), e.g. in
tech-notes/rebalance.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
