sanpwc commented on code in PR #759:
URL: https://github.com/apache/ignite-3/pull/759#discussion_r857890775
##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/DistributedConfigurationStorage.java:
##########
@@ -306,7 +306,12 @@ public boolean onUpdate(@NotNull WatchEvent events) {
long newChangeId = masterKeyEntry.revision();
- assert newChangeId > changeId.get();
+ assert newChangeId >= changeId.get();
+
+ // skip already processed update
+ if (changeId.get() == newChangeId) {
Review Comment:
Ass was mentioned above it seems that there's nothing to skip because all
watches are resisted on start.
##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/DistributedConfigurationStorage.java:
##########
@@ -306,7 +306,12 @@ public boolean onUpdate(@NotNull WatchEvent events) {
long newChangeId = masterKeyEntry.revision();
- assert newChangeId > changeId.get();
+ assert newChangeId >= changeId.get();
+
+ // skip already processed update
+ if (changeId.get() == newChangeId) {
Review Comment:
As was mentioned above it seems that there's nothing to skip because all
watches are resisted on start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
