ibessonov commented on code in PR #787:
URL: https://github.com/apache/ignite-3/pull/787#discussion_r858828409
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java:
##########
@@ -29,43 +29,56 @@
* POC version, that represents a combination between a replicated TX-aware MV
storage and physical MV storage. Their API are very similar,
* although there are very important differences that will be addressed in the
future.
*/
-public interface MvPartitionStorage {
+public interface MvPartitionStorage extends AutoCloseable {
/**
* Reads the value from the storage as it was at the given timestamp.
{@code null} timestamp means reading the latest value.
*
- * @param key Key.
+ * @param rowId Row id.
* @param timestamp Timestamp.
Review Comment:
Not nullable anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
