alex-plekhanov commented on code in PR #9988:
URL: https://github.com/apache/ignite/pull/9988#discussion_r861518548
##########
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2Utils.java:
##########
@@ -569,13 +588,28 @@ public static boolean
checkAndStartNotStartedCache(GridKernalContext ctx, GridH2
return false;
}
+ /**
+ * @param cls The class whose convertibility is to be tested.
+ * @param colType Column target type.
+ * @return Whether specified class can be implicitly converted to the
specified type.
+ * @see #wrap(CacheObjectValueContext, Object, int)
+ */
+ public static boolean isConvertableToColumnType(Class<?> cls, int colType)
{
Review Comment:
But now default `return false` implementation looks illogical for indexing.
Perhaps we shouldn't provide default implementation for this method. WDYT? I
doubt anyone have indexing implementation other than ignite-indexing, so we
should not worried about backward compatibility (at least, new non-default
methods were added recently and nobody complained)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
