ibessonov commented on code in PR #791: URL: https://github.com/apache/ignite-3/pull/791#discussion_r861643704
########## modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointReadWriteLockTest.java: ########## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.pagememory.persistence.checkpoint; + +import static java.util.concurrent.CompletableFuture.runAsync; +import static java.util.concurrent.Executors.newSingleThreadExecutor; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.fail; + +import java.util.concurrent.TimeUnit; +import org.apache.ignite.internal.thread.NamedThreadFactory; +import org.junit.jupiter.api.Test; + +/** + * For {@link CheckpointReadWriteLock} testing. + */ +public class CheckpointReadWriteLockTest { + @Test + void testReadLock() throws Exception { + CheckpointReadWriteLock lock0 = new CheckpointReadWriteLock(new ReentrantReadWriteLockWithTracking()); + CheckpointReadWriteLock lock1 = new CheckpointReadWriteLock(new ReentrantReadWriteLockWithTracking()); + + lock1.writeLock(); + + lock0.readLock(); + lock1.readLock(); + + assertEquals(1, lock0.getReadHoldCount()); + assertEquals(0, lock1.getReadHoldCount()); + + lock1.writeUnlock(); + + runAsync(() -> { + assertEquals(0, lock0.getReadHoldCount()); + assertEquals(0, lock1.getReadHoldCount()); + + lock0.readLock(); + lock1.readLock(); + + assertEquals(1, lock0.getReadHoldCount()); + assertEquals(1, lock1.getReadHoldCount()); + + lock0.readUnlock(); + lock1.readUnlock(); + + assertEquals(0, lock0.getReadHoldCount()); + assertEquals(0, lock1.getReadHoldCount()); + }).get(1, TimeUnit.SECONDS); + + lock1.writeLock(); + + assertEquals(1, lock0.getReadHoldCount()); + assertEquals(0, lock1.getReadHoldCount()); + + lock0.readUnlock(); + lock1.readUnlock(); + + assertEquals(0, lock0.getReadHoldCount()); + assertEquals(0, lock1.getReadHoldCount()); + } + + @Test + void testTryReadLock() throws Exception { + CheckpointReadWriteLock lock0 = new CheckpointReadWriteLock(new ReentrantReadWriteLockWithTracking()); + CheckpointReadWriteLock lock1 = new CheckpointReadWriteLock(new ReentrantReadWriteLockWithTracking()); + CheckpointReadWriteLock lock2 = new CheckpointReadWriteLock(new ReentrantReadWriteLockWithTracking()); + + lock2.writeLock(); + + assertTrue(lock0.tryReadLock()); + assertTrue(lock1.tryReadLock(1, TimeUnit.MILLISECONDS)); + + assertTrue(lock2.tryReadLock()); + assertTrue(lock2.tryReadLock(1, TimeUnit.MILLISECONDS)); + + assertEquals(1, lock0.getReadHoldCount()); + assertEquals(1, lock1.getReadHoldCount()); + assertEquals(0, lock2.getReadHoldCount()); + + runAsync(() -> { + assertEquals(0, lock0.getReadHoldCount()); + assertEquals(0, lock1.getReadHoldCount()); + assertEquals(0, lock2.getReadHoldCount()); + + assertFalse(lock2.tryReadLock()); + + try { + assertFalse(lock2.tryReadLock(1, TimeUnit.MILLISECONDS)); + } catch (InterruptedException e) { + fail(e); + } + + assertEquals(0, lock0.getReadHoldCount()); + assertEquals(0, lock1.getReadHoldCount()); + assertEquals(0, lock2.getReadHoldCount()); + }).get(1, TimeUnit.SECONDS); + + lock2.writeUnlock(); + + runAsync(() -> { + try { + assertTrue(lock0.tryReadLock()); + assertTrue(lock1.tryReadLock(1, TimeUnit.MILLISECONDS)); + + assertTrue(lock2.tryReadLock()); + assertTrue(lock2.tryReadLock(1, TimeUnit.MILLISECONDS)); + + assertEquals(1, lock0.getReadHoldCount()); + assertEquals(1, lock1.getReadHoldCount()); + assertEquals(2, lock2.getReadHoldCount()); + + lock0.readUnlock(); + lock1.readUnlock(); + lock2.readUnlock(); + + assertEquals(0, lock0.getReadHoldCount()); + assertEquals(0, lock1.getReadHoldCount()); + assertEquals(1, lock2.getReadHoldCount()); + + lock2.readUnlock(); + + assertEquals(0, lock2.getReadHoldCount()); + } catch (InterruptedException e) { + fail(e); + } + }).get(1, TimeUnit.SECONDS); + + lock2.writeLock(); + + assertEquals(1, lock0.getReadHoldCount()); + assertEquals(1, lock1.getReadHoldCount()); + assertEquals(0, lock2.getReadHoldCount()); + + lock0.readUnlock(); + lock1.readUnlock(); + lock2.readUnlock(); + + assertEquals(0, lock0.getReadHoldCount()); + assertEquals(0, lock1.getReadHoldCount()); + assertEquals(0, lock2.getReadHoldCount()); + } + + @Test + void testCheckpointLockIsHeldByThread() throws Exception { + CheckpointReadWriteLock lock0 = new CheckpointReadWriteLock(new ReentrantReadWriteLockWithTracking()); + CheckpointReadWriteLock lock1 = new CheckpointReadWriteLock(new ReentrantReadWriteLockWithTracking()); + CheckpointReadWriteLock lock2 = new CheckpointReadWriteLock(new ReentrantReadWriteLockWithTracking()); + + assertFalse(lock0.checkpointLockIsHeldByThread()); + assertFalse(lock1.checkpointLockIsHeldByThread()); + assertFalse(lock2.checkpointLockIsHeldByThread()); + + lock0.writeLock(); + lock1.readLock(); + + assertTrue(lock0.checkpointLockIsHeldByThread()); + assertTrue(lock1.checkpointLockIsHeldByThread()); + + runAsync( + () -> assertTrue(lock2.checkpointLockIsHeldByThread()), + newSingleThreadExecutor(new NamedThreadFactory("checkpoint-runner")) + ).get(1, TimeUnit.SECONDS); + + runAsync(() -> { + assertFalse(lock0.checkpointLockIsHeldByThread()); + assertFalse(lock1.checkpointLockIsHeldByThread()); + assertFalse(lock2.checkpointLockIsHeldByThread()); + }).get(1, TimeUnit.SECONDS); + + runAsync(() -> { Review Comment: Thread name, for example. And, all threads started from tests should be stopped somewhere in "after test". It's not implemented yet, but that would be much easier with our own factories. We can ignore it for now, I guess, and refactor everything in the future. Just keep in mind, there always may be reasons to use custom methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
