sanpwc commented on code in PR #759:
URL: https://github.com/apache/ignite-3/pull/759#discussion_r861761233
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -195,16 +213,18 @@ public TableManager(
/** {@inheritDoc} */
@Override
public void start() {
+ tablesCfg.tables().any().replicas().listen(this::onUpdateReplicas);
+
+ registerRebalanceListeners();
+
((ExtendedTableConfiguration)
tablesCfg.tables().any()).schemas().listenElements(new
ConfigurationNamedListListener<>() {
@Override
public CompletableFuture<?>
onCreate(ConfigurationNotificationEvent<SchemaView> schemasCtx) {
return onSchemaCreate(schemasCtx);
}
});
- ((ExtendedTableConfiguration)
tablesCfg.tables().any()).assignments().listen(assignmentsCtx -> {
- return onUpdateAssignments(assignmentsCtx);
- });
+ ((ExtendedTableConfiguration)
tablesCfg.tables().any()).assignments().listen(this::onUpdateAssignments);
Review Comment:
Let's also add a test **within separate ticket** that will check that
partially applied rebalance-invokes because of wrapped nodeStoppingException
in the middle will abort ms notification flow and properly recovered on
nodeRestart/leaderRe-election. I mean success invokes for ssome k paritions and
RuntimeException(NodeStoppingExpcetion) on k + 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
