Vladsz83 commented on code in PR #9987:
URL: https://github.com/apache/ignite/pull/9987#discussion_r861839414
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rel/IgniteSort.java:
##########
@@ -92,9 +125,12 @@ public IgniteSort(RelInput input) {
if (isEnforcer() || required.getConvention() !=
IgniteConvention.INSTANCE)
return null;
- RelCollation collation = TraitUtils.collation(required);
+ RelCollation relCollation = TraitUtils.collation(required);
+
+ if (!relCollation.satisfies(collation) ||
!collation.satisfies(relCollation))
Review Comment:
As far as I understand, we should not pass if child nodes require other or
extended collation:
if(!collation.satisfies(requiredCollation))
return null;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
