tkalkirill commented on code in PR #806:
URL: https://github.com/apache/ignite-3/pull/806#discussion_r875647385
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##########
@@ -194,32 +194,18 @@ protected void body() {
waitCheckpointEvent();
if (skipCheckpointOnNodeStop && (isCancelled() ||
shutdownNow)) {
- if (log.isInfoEnabled()) {
+ if (log.isWarnEnabled()) {
log.warn("Skipping last checkpoint because node is
stopping.");
}
return;
}
- CompletableFuture<?> enableChangeAppliedFuture =
this.enableChangeAppliedFuture;
-
- if (enableChangeAppliedFuture != null) {
- enableChangeAppliedFuture.complete(null);
-
- this.enableChangeAppliedFuture = null;
- }
-
- if (checkpointsEnabled) {
- doCheckpoint();
- } else {
- synchronized (this) {
-
scheduledCheckpointProgress.nextCheckpointNanos(MILLISECONDS.toNanos(nextCheckpointInterval()));
- }
- }
+ doCheckpoint();
}
// Final run after the cancellation.
- if (checkpointsEnabled && !shutdownNow) {
+ if (!shutdownNow) {
Review Comment:
Discussed in person, decided to remove
**Checkpointer#skipCheckpointOnNodeStop** for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
