rpuch commented on code in PR #814: URL: https://github.com/apache/ignite-3/pull/814#discussion_r877788392
########## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/PageMemoryMvPartitionStorage.java: ########## @@ -0,0 +1,515 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.storage.pagememory.mv; + +import static org.apache.ignite.internal.pagememory.PageIdAllocator.FLAG_AUX; + +import java.nio.ByteBuffer; +import java.util.NoSuchElementException; +import java.util.Objects; +import java.util.UUID; +import java.util.concurrent.atomic.AtomicLong; +import java.util.function.Predicate; +import org.apache.ignite.configuration.schemas.table.TableView; +import org.apache.ignite.internal.pagememory.PageMemoryDataRegion; +import org.apache.ignite.internal.pagememory.datapage.DataPageReader; +import org.apache.ignite.internal.pagememory.metric.IoStatisticsHolderNoOp; +import org.apache.ignite.internal.pagememory.util.PageLockListenerNoOp; +import org.apache.ignite.internal.schema.BinaryRow; +import org.apache.ignite.internal.schema.ByteBufferRow; +import org.apache.ignite.internal.storage.MvPartitionStorage; +import org.apache.ignite.internal.storage.NoUncommittedVersionException; +import org.apache.ignite.internal.storage.RowId; +import org.apache.ignite.internal.storage.StorageException; +import org.apache.ignite.internal.storage.StorageUtils; +import org.apache.ignite.internal.storage.TxIdMismatchException; +import org.apache.ignite.internal.storage.pagememory.VolatilePageMemoryDataRegion; +import org.apache.ignite.internal.tx.Timestamp; +import org.apache.ignite.internal.util.Cursor; +import org.apache.ignite.internal.util.IgniteCursor; +import org.apache.ignite.lang.IgniteInternalCheckedException; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +/** + * Implementation of {@link MvPartitionStorage} using Page Memory. + * + * @see MvPartitionStorage + */ +public class PageMemoryMvPartitionStorage implements MvPartitionStorage { + private static final byte[] TOMBSTONE_PAYLOAD = new byte[0]; + private static final Predicate<BinaryRow> MATCH_ALL = row -> true; + + private final int partitionId; + private final int groupId; + + private final VersionChainFreeList versionChainFreeList; Review Comment: Why do I need to separate them with empty lines? It makes sense to separate fields with blank lines if you want to logicallly group them. 2 fields are strongly connected by their meaning, ok, we put them in the same block. Fields inside a block are declared without blank lines between them. Blocks are separated with blank lines. If we just ALWAYS separate field declarations with blank lines, we lose the ability to group them logically, but we gain nothing in return. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
