nizhikov commented on code in PR #9907:
URL: https://github.com/apache/ignite/pull/9907#discussion_r880667435
##########
modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerConsistencyTest.java:
##########
@@ -279,42 +290,39 @@ private void readRepair(AtomicInteger brokenParts, String
cacheName, Integer fix
assertTrue(VisorConsistencyStatusTask.MAP.isEmpty());
assertContains(log, testOut.toString(),
CONSISTENCY_VIOLATIONS_FOUND);
- assertContains(log, testOut.toString(), "[found=1, fixed=" +
(fixesPerEntry != null ? fixesPerEntry.toString() : ""));
+ assertContains(log, testOut.toString(), "[found=1, repaired=" +
repairsPerEntry.toString());
assertEquals(EXIT_CODE_OK, execute("--cache", "idle_verify"));
- if (fixesPerEntry != null)
- if (fixesPerEntry > 0) {
- brokenParts.decrementAndGet();
+ if (repairsPerEntry > 0) {
+ brokenParts.decrementAndGet();
- if (brokenParts.get() > 0)
- assertContains(log, testOut.toString(),
- "conflict partitions has been found:
[counterConflicts=0, hashConflicts=" + brokenParts);
- else
- assertContains(log, testOut.toString(), "no conflicts
have been found");
- }
- else
+ if (brokenParts.get() > 0)
assertContains(log, testOut.toString(),
- "conflict partitions has been found:
[counterConflicts=0, hashConflicts=" + brokenParts); // Nothing fixed.
+ "conflict partitions has been found:
[counterConflicts=0, hashConflicts=" + brokenParts);
+ else
+ assertContains(log, testOut.toString(), "no conflicts have
been found");
+ }
+ else
+ assertContains(log, testOut.toString(),
Review Comment:
multiline if require braces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
