PakhomovAlexander commented on code in PR #816: URL: https://github.com/apache/ignite-3/pull/816#discussion_r885083833
########## modules/configuration/src/main/java/org/apache/ignite/internal/rest/configuration/ClusterConfigurationController.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.rest.configuration; + +import io.micronaut.http.MediaType; +import io.micronaut.http.annotation.Body; +import io.micronaut.http.annotation.Consumes; +import io.micronaut.http.annotation.Controller; +import io.micronaut.http.annotation.Get; +import io.micronaut.http.annotation.Patch; +import io.micronaut.http.annotation.PathVariable; +import io.micronaut.http.annotation.Produces; +import io.swagger.v3.oas.annotations.Operation; +import io.swagger.v3.oas.annotations.media.Content; +import io.swagger.v3.oas.annotations.media.Schema; +import io.swagger.v3.oas.annotations.responses.ApiResponse; +import io.swagger.v3.oas.annotations.tags.Tag; +import jakarta.inject.Named; +import org.apache.ignite.internal.configuration.rest.presentation.ConfigurationPresentation; + +/** + * Cluster configuration controller. + */ +@Controller("/management/v1/configuration/cluster/") +@ApiResponse(responseCode = "400", description = "Incorrect configuration") +@ApiResponse(responseCode = "500", description = "Internal error") +@Tag(name = "clusterConfiguration") +public class ClusterConfigurationController extends AbstractConfigurationController { + + public ClusterConfigurationController(@Named("clusterCfgPresentation") ConfigurationPresentation<String> clusterCfgPresentation) { + super(clusterCfgPresentation); + } + + /** + * Returns cluster configuration in HOCON format. + * + * @return the whole cluster configuration in HOCON format. + */ + @Operation(operationId = "getClusterConfiguration") + @ApiResponse( + responseCode = "200", + content = @Content(mediaType = MediaType.TEXT_PLAIN, schema = @Schema(type = "string")), + description = "Get cluster configuration") + @Produces(MediaType.TEXT_PLAIN) + @Get + public String getConfiguration() { + return super.getConfiguration(); + } + + /** + * Returns configuration in HOCON format represented by path. + * + * @param path to represent a cluster configuration. + * @return system configuration in HOCON format represented by given path. + */ + @Operation(operationId = "getClusterConfigurationByPath") + @ApiResponse(responseCode = "200", + content = @Content(mediaType = MediaType.TEXT_PLAIN, + schema = @Schema(type = "string")), + description = "Configuration represented by path") + @Produces(MediaType.TEXT_PLAIN) + @Get("/{path}") + public String getConfigurationByPath(@PathVariable String path) { + return super.getConfigurationByPath(path); + } + + /** + * Updates cluster configuration in HOCON format. + * + * @param updatedConfiguration the cluster configuration to update. + */ + @Operation(operationId = "updateClusterConfiguration") + @ApiResponse(responseCode = "200", description = "Configuration updated") + @Consumes(MediaType.TEXT_PLAIN) + @Patch + public void updateConfiguration(@Body String updatedConfiguration) throws Throwable { Review Comment: Good point, will try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
