PakhomovAlexander commented on code in PR #816:
URL: https://github.com/apache/ignite-3/pull/816#discussion_r885593591
##########
modules/cluster-management/pom.xml:
##########
@@ -49,17 +49,26 @@
<dependency>
<groupId>org.apache.ignite</groupId>
- <artifactId>ignite-rest</artifactId>
+ <artifactId>ignite-vault</artifactId>
</dependency>
<dependency>
<groupId>org.apache.ignite</groupId>
- <artifactId>ignite-vault</artifactId>
+ <artifactId>ignite-rest-api</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>io.micronaut</groupId>
+ <artifactId>micronaut-http</artifactId>
+ <version>${micronaut.version}</version>
Review Comment:
> Why? There should be no difference between using a bom and declaring
dependencies directly
Yes, you are right, there is no difference.
> Can you provide an example please?
Micronaut-bom includes a lot of other libraries' version definitions, for
example, neo4j.version, h2.version, and many more. So, Ignite 3 will have them
included to dependency management too. Maybe that is not a problem but if
Iginite 3 would like to support neo4j with a version that is different from
micronaut-bom then we might face an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
