tkalkirill commented on code in PR #822:
URL: https://github.com/apache/ignite-3/pull/822#discussion_r886310363
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/impl/PageMemoryNoStoreImpl.java:
##########
@@ -167,23 +169,26 @@ public class PageMemoryNoStoreImpl implements PageMemory {
/**
* Constructor.
*
- * @param directMemoryProvider Memory allocator to use.
* @param dataRegionConfig Data region configuration.
* @param ioRegistry IO registry.
* @param pageSize Page size in bytes.
*/
public PageMemoryNoStoreImpl(
- DirectMemoryProvider directMemoryProvider,
PageMemoryDataRegionConfiguration dataRegionConfig,
PageIoRegistry ioRegistry,
// TODO: IGNITE-17017 Move to common config
int pageSize
) {
- this.directMemoryProvider = directMemoryProvider;
this.ioRegistry = ioRegistry;
this.trackAcquiredPages = false;
this.dataRegionConfigView = dataRegionConfig.value();
+ if (dataRegionConfigView.memoryAllocator() instanceof
UnsafeMemoryAllocator) {
+ throw new IgniteInternalException("Unexpected memory allocator: "
+ dataRegionConfigView.memoryAllocator());
Review Comment:
I think at the beginning it is necessary to define the general format for
errors related to the configuration, and then we will redo it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
