tkalkirill commented on code in PR #831:
URL: https://github.com/apache/ignite-3/pull/831#discussion_r886659194
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PageMemoryStorageEngine.java:
##########
@@ -64,26 +70,18 @@ public PageMemoryStorageEngine(
public void start() {
int pageSize = engineConfig.pageSize().value();
- VolatilePageMemoryDataRegion defaultRegion = new
VolatilePageMemoryDataRegion(
- engineConfig.defaultRegion(),
- ioRegistry, pageSize
- );
+ addDataRegion(DEFAULT_DATA_REGION_NAME, engineConfig.defaultRegion(),
pageSize);
- defaultRegion.start();
+ // TODO: IGNITE-17066 Add handling deleting/updating data regions
configuration
+ engineConfig.regions().listenElements(new
ConfigurationNamedListListener<>() {
Review Comment:
Discussed personally, leave as is.
@sashapolo doesn't need move to constructor, @ibessonov made a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
