sanpwc commented on code in PR #839:
URL: https://github.com/apache/ignite-3/pull/839#discussion_r890106796
##########
modules/core/src/main/java/org/apache/ignite/internal/causality/VersionedValue.java:
##########
@@ -594,7 +594,7 @@ private void trimToSize(long causalityToken) {
* @param causalityToken Causality token.
*/
private static void checkToken(long actualToken, long causalityToken) {
Review Comment:
Not related to proposed changes but...
Both actualToken and causalityToken are causality tokens, I'd rather use
"appliedToken" and "candidateToken" or similar. If you don't mind, lets fix it
here. Besides that checkToken is rather assertToken, up to you though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
