ptupitsyn commented on code in PR #865:
URL: https://github.com/apache/ignite-3/pull/865#discussion_r892301464
##########
modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSession.java:
##########
@@ -82,15 +83,17 @@ public ClientSession(
/** {@inheritDoc} */
@Override
public ResultSet execute(@Nullable Transaction transaction, String query,
@Nullable Object... arguments) {
- // TODO IGNITE-17057.
- throw new UnsupportedOperationException("Not implemented yet.");
+ Objects.requireNonNull(query);
+
+ return new ResultSetImpl(sync(executeAsync(transaction, query,
arguments)));
Review Comment:
Good points.
Regarding sync/await/join - I've filed [IGNITE-17135 SQL API: Exceptions are
different on server and
client](https://issues.apache.org/jira/browse/IGNITE-17135) and added a bunch
of TODOs in code. Let's handle it there. We should definitely unify the
approach for sync-over-async exception handling.
> What do you think about default implementation at the Session interface?
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
