tledkov-gridgain commented on code in PR #865:
URL: https://github.com/apache/ignite-3/pull/865#discussion_r892313916
##########
modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSession.java:
##########
@@ -82,15 +83,17 @@ public ClientSession(
/** {@inheritDoc} */
@Override
public ResultSet execute(@Nullable Transaction transaction, String query,
@Nullable Object... arguments) {
- // TODO IGNITE-17057.
- throw new UnsupportedOperationException("Not implemented yet.");
+ Objects.requireNonNull(query);
+
+ return new ResultSetImpl(sync(executeAsync(transaction, query,
arguments)));
Review Comment:
I guess `CompletionException` is not expected by user at the synchronous API.
Could we make temporary sync/await method with convert to SqlException?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
