sashapolo commented on code in PR #873:
URL: https://github.com/apache/ignite-3/pull/873#discussion_r893391125
##########
modules/core/src/main/java/org/apache/ignite/internal/properties/IgniteProductVersion.java:
##########
@@ -47,11 +48,15 @@ public class IgniteProductVersion implements Serializable {
/** Flag indicating if this is a snapshot release. */
private final boolean isSnapshot;
- private IgniteProductVersion(byte major, byte minor, byte maintenance,
boolean isSnapshot) {
+ /** Alpha version part or an empty string if this is not an alpha release.
*/
+ private final String alphaVersion;
Review Comment:
Because I don't know if we actually need to change it a little bit in order
to accommodate beta version, for example. We can switch to a byte later if
needed.
##########
modules/core/src/main/java/org/apache/ignite/internal/properties/IgniteProductVersion.java:
##########
@@ -47,11 +48,15 @@ public class IgniteProductVersion implements Serializable {
/** Flag indicating if this is a snapshot release. */
private final boolean isSnapshot;
- private IgniteProductVersion(byte major, byte minor, byte maintenance,
boolean isSnapshot) {
+ /** Alpha version part or an empty string if this is not an alpha release.
*/
+ private final String alphaVersion;
Review Comment:
Because I don't know if we actually need to change it a little bit in order
to accommodate the beta version, for example. We can switch to a byte later if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
