alievmirza commented on code in PR #872:
URL: https://github.com/apache/ignite-3/pull/872#discussion_r893425314
##########
modules/metastorage-server/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -829,15 +829,13 @@ private Collection<Entry> doGetAll(Collection<byte[]>
keys, long rev) {
/**
* Gets the value by key and revision.
*
- * @param key Target key.
- * @param rev Target revision.
- * @param exactRev {@code true} if searching for exact revision, {@code
false} if rev is an upper bound (inclusive).
+ * @param key Target key.
+ * @param revUpperBound Target upper bound of revision.
* @return Value.
*/
@NotNull
- Entry doGet(byte[] key, long rev, boolean exactRev) {
- assert rev == LATEST_REV && !exactRev || rev > LATEST_REV :
- "Invalid arguments: [rev=" + rev + ", exactRev=" + exactRev +
']';
+ Entry doGet(byte[] key, long revUpperBound) {
+ assert rev >= LATEST_REV : "Invalid arguments: [rev=" + rev + ']';
Review Comment:
This assert is unclear for me, should be there `revUpperBound` instead of
`rev`? Because now `rev` refers to `RocksDbKeyValueStorage#rev`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
